Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11403#discussion_r55248273
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/broadcastMode.scala
---
@@ -25,6 +25,11 @@ import org.apache.spark.sql.catalyst.InternalRow
*/
trait BroadcastMode {
def transform(rows: Array[InternalRow]): Any
+
+ /**
+ * Returns true iff this [[BroadcastMode]] generates the same result as
`other`.
+ */
+ def compatibleWith(other: BroadcastMode): Boolean
--- End diff --
compatibleWith is not iff and not valid here. partitioning is different
since it doesn't have to be both ways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
