Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11534#discussion_r55411268
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -801,43 +780,63 @@ private[spark] class BlockManager(
         }
     
         var blockWasSuccessfullyStored = false
    -    var result: PutResult = null
    +    var iteratorFromFailedMemoryStorePut: Option[Iterator[Any]] = None
     
         putBlockInfo.synchronized {
    --- End diff --
    
    I think this was a carryover from the very old code where we synchronized 
on the BlockInfo objects themselves instead of using our new lock interface. 
I'll remove this to clean things up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to