Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11403#discussion_r55442096
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala ---
    @@ -31,13 +32,26 @@ class SparkPlanInfo(
         val simpleString: String,
         val children: Seq[SparkPlanInfo],
         val metadata: Map[String, String],
    -    val metrics: Seq[SQLMetricInfo])
    +    val metrics: Seq[SQLMetricInfo]) {
    +
    +  override def hashCode(): Int = {
    +    simpleString.hashCode
    --- End diff --
    
    We only need to make sure that those object equal with each other should 
have the same hashCode, but the hashCode does not need to considering all the 
members.
    
    Using simpleString here should be enough to have good hashCode (be good 
enough to distinguish each other within a plan)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to