Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11243#discussion_r55449966
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -182,11 +183,16 @@ case class CaseWhen(branches: Seq[(Expression,
Expression)], elseValue: Option[E
generatedCode += "}\n" * cases.size
- s"""
+ // Methods that are too long cannot be compiled, so fall back to
interpreting
+ if (generatedCode.length > 1000) {
--- End diff --
Can we do the switch based on number of branches? for example, 10 or 20
switches.
Because whole stage codegen can't work with CodegenFallback, If we do so,
we can know when we will do the fallback, we can still support CaseWhen in
whole stage codegen if only have a few branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
