Github user yzhou2001 commented on the pull request:
https://github.com/apache/spark/pull/11184#issuecomment-194047202
I'm not sure whether the visitor pattern is a good choice here. First
introduction of a visitor just for this fix would see no less code changes;
Second Scala pattern matching capabilities notwithstanding, it also boils down
to the model hierarchy stability vs. capability stability. Pattern matching
could have been utilized here if not for concerns on maintaining the original
exception throwing from the "dataType" method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
