Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11585#issuecomment-194076759
  
    After offline discussion with @sameeragarwal , we agreed that 1) the 
constraints should only used in logical plan 2) we should use the `IsNotNull()` 
inserted by #11372, 3) we do need to re-order the conditions anymore, just do 
that in Filter. 4) The `IsNotNull` from join ares pushed down into it's 
children, join requires nullability propagated from it's children, that's 
another story.
    
    I will update this PR based on these, and revert #11511 
    
    cc @yhuai @nongli 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to