Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11596#discussion_r55471264
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala 
---
    @@ -445,4 +461,98 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest 
with SQLTestUtils {
           "f1", "b[0].f1", "f1", "c[foo]", "d[0]"
         )
       }
    +
    +  test("SQL generator for explode in projection list") {
    +    // Basic Explode
    +    checkHiveQl("SELECT explode(array(1,2,3)) FROM src")
    +
    +    // Explode with Alias
    +    checkHiveQl("SELECT explode(array(1,2,3)) as value FROM src")
    +
    +    // Explode without FROM
    +    checkHiveQl("select explode(array(1,2,3)) AS gencol")
    +
    +    // non-generated columns in projection list
    +    checkHiveQl("SELECT key as c1, explode(array(1,2,3)) as c2, value as 
c3 FROM t1")
    +  }
    +
    +  test("SQL generation for json_tuple as generator") {
    +    checkHiveQl("SELECT key, json_tuple(jstring, 'f1', 'f2', 'f3', 'f4', 
'f5') FROM parquet_t3")
    +  }
    +
    +  test("SQL generation for lateral views") {
    --- End diff --
    
    Please add another test case for joining the lateral view with a regular 
table. Thanks! 
    
    ```LATERAL VIEW ......,  t1 as table1```  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to