Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11592#discussion_r55471486
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -136,7 +136,16 @@ case class CaseWhen(branches: Seq[(Expression,
Expression)], elseValue: Option[E
}
}
+ def shouldCodegen: Boolean = {
+ branches.length < CaseWhen.MAX_NUMBER_OF_SWITCHES
+ }
+
override def genCode(ctx: CodegenContext, ev: ExprCode): String = {
+ if (!shouldCodegen) {
+ // Fallback to interpreted mode if there are too many branches, or
it may reach the
+ // 64K limit (number of bytecode for single Java method).
+ return super.genCode(ctx, ev)
--- End diff --
this super is slightly brittle. Can you see if there is a way in Scala to
explicitly call genCode in CodegenFallback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
