Github user javadba commented on a diff in the pull request:
https://github.com/apache/spark/pull/1542#discussion_r15389491
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -130,7 +130,7 @@ private[spark] abstract class MapOutputTracker(conf:
SparkConf) extends Logging
if (statuses == null) {
logInfo("Don't have map outputs for shuffle " + shuffleId + ",
fetching them")
var fetchedStatuses: Array[MapStatus] = null
- fetching.synchronized {
+ shuffleId.toString.intern.synchronized {
--- End diff --
Yes I see your point and agree there is a problem in the proposed fix..
My fix is incorrect in that we need to match the outer
shuffleId.toString.intern.synchronized to the inner
shuffleId.toString.intern.wait().
Then the code should look like this:
val monitor = shuffleId.toString.intern
monitor.synchronized {
..
monitor.wait()
}
Do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
