Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1586#discussion_r15390507
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -208,6 +208,69 @@ case class EndsWith(left: Expression, right: 
Expression)
       def compare(l: String, r: String) = l.endsWith(r)
     }
     
    +trait LengthExpression {
    +  self: UnaryExpression =>
    +  type EvaluatedType = Any
    +
    +  def dataType = IntegerType
    +  override def foldable = child.foldable
    +  def nullable = child.nullable
    +
    +  override def eval(input: Row): EvaluatedType = {
    --- End diff --
    
    I'd just put this in `Strlen` since that is the only place it is used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to