Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/11549#discussion_r55591400 --- Diff: R/pkg/R/mllib.R --- @@ -51,13 +45,12 @@ setClass("PipelineModel", representation(model = "jobj")) #' summary(model) #'} setMethod("glm", signature(formula = "formula", family = "ANY", data = "DataFrame"), - function(formula, family = c("gaussian", "binomial"), data, lambda = 0, alpha = 0, - standardize = TRUE, solver = "auto") { + function(formula, family = c("gaussian", "binomial", "poisson", "gamma"), data, + lambda = 0, solver = "irls") { --- End diff -- I would keep the solver to 'auto', so that we can change the implementation of the solver without regression. However, the option 'irls' is available for users who want to use it. As for the other options for the solver, see my comment in the ticket.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org