Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11581#discussion_r55725405
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -117,17 +126,18 @@ final class DecisionTreeRegressionModel private[ml] (
override val rootNode: Node,
override val numFeatures: Int)
extends PredictionModel[Vector, DecisionTreeRegressionModel]
- with DecisionTreeModel with DecisionTreeRegressorParams with
Serializable {
+ with DecisionTreeModel with DecisionTreeRegressorParams with MLWritable
with Serializable {
/** @group setParam */
def setVarianceCol(value: String): this.type = set(varianceCol, value)
require(rootNode != null,
- "DecisionTreeClassificationModel given null rootNode, but it requires
a non-null rootNode.")
+ "DecisionTreeRegressionModel given null rootNode, but it requires a
non-null rootNode.")
/**
* Construct a decision tree regression model.
- * @param rootNode Root node of tree, with other nodes attached.
+ *
+ * @param rootNode Root node of tree, with other nodes attached.
--- End diff --
Same here, I don't know either.
On Thursday, March 10, 2016, jkbradley <[email protected]> wrote:
> In
>
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
> <https://github.com/apache/spark/pull/11581#discussion_r55724843>:
>
> >
> > /**
> > * Construct a decision tree regression model.
> > - * @param rootNode Root node of tree, with other nodes attached.
> > + *
> > + * @param rootNode Root node of tree, with other nodes attached.
>
> Thanks! I can't figure out how to fix IntelliJ imports ever since I
> updated it...
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/11581/files#r55724843>.
>
--
Cheers,
Xusen Yin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
