Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11241#issuecomment-195023668
Looks great. My remaining comments are relatively minor. About making it
configurable, it's probably OK as long as we don't also document it. I just
don't want the user to have to think about their applications at this level of
detail. We want Spark to be easy to use without a ton of tweaking. Maybe that's
not really the case today but it's a goal we're striving towards.
(TL;DR keep the config but don't document it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
