Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/11621#discussion_r55774471
--- Diff: python/pyspark/ml/wrapper.py ---
@@ -34,10 +34,12 @@ class JavaWrapper(Params):
__metaclass__ = ABCMeta
- #: The wrapped Java companion object. Subclasses should initialize
- #: it properly. The param values in the Java object should be
- #: synced with the Python wrapper in fit/transform/evaluate/copy.
- _java_obj = None
--- End diff --
@mengxr @jkbradley it seems like this should not be a static member, right?
From what I could tell, it's not even being used since the assignment is
always to `self._java_obj`. So I made a change to make it a member instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
