Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/11596#discussion_r55791864 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -94,6 +94,12 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext: SQLContext) extends Loggi case Distinct(p: Project) => projectToSQL(p, isDistinct = true) + case p@ Project(_, g: Generate) => + generateToSQL(p) + + case g: Generate => --- End diff -- @cloud-fan Sorry Wenchen for getting back to you a bit late. Actually the two cases do different things. First one builds the top level SELECT clause and the second one builds the LATERAL VIEW clause. Do you have any suggestion for a better name for these two functions ? :-)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org