Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55792469
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
#' @name [
-setMethod("[", signature(x = "DataFrame", i = "missing"),
- function(x, i, j, ...) {
- if (is.numeric(j)) {
- cols <- columns(x)
- j <- cols[j]
- }
- if (length(j) > 1) {
- j <- as.list(j)
+setMethod("[", signature(x = "DataFrame"),
+ function(x, i, j, ..., drop=T) {
+ # Perform filtering first if needed
+ filtered <- if (missing(i)) {
+ x
+ } else {
+ if (class(i) != "Column") {
+ stop(paste0("Expressions other than filtering predicates
are not supported ",
+ "in the first parameter of subsetting operator [."))
--- End diff --
suggest `extract operator [ or subset()`, as [ is referred to as 'extract'
[here](https://stat.ethz.ch/R-manual/R-devel/library/base/html/Extract.html),
and subset() calls also go here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
