Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11647#discussion_r55872639
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
 ---
    @@ -36,15 +36,16 @@ import org.apache.spark.sql.catalyst.rules._
     object Canonicalize extends RuleExecutor[Expression] {
       override protected def batches: Seq[Batch] =
         Batch(
    -      "Expression Canonicalization", FixedPoint(100),
    +      "Expression Canonicalization", Once,
    --- End diff --
    
    Its kind of confusing for this to be a RuleExecutor if we are only going to 
run it once and its only doing matches.  Should we just move this into 
`Expression`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to