Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11658#discussion_r55916858
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -54,8 +55,26 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
def toSQL: String = {
val canonicalizedPlan = Canonicalizer.execute(logicalPlan)
+ val outputNames = logicalPlan.output.map(_.name)
+ val qualifiers = logicalPlan.output.flatMap(_.qualifiers).distinct
+
+ // Keep the qualifier information by using it as sub-query name, if
there is only one qualifier
+ // present.
+ val finalName = if (qualifiers.isEmpty || qualifiers.length > 1) {
+ SQLBuilder.newSubqueryName
+ } else {
+ qualifiers.head
+ }
+
+ // Canonicalizer will remove all naming information, we should add it
back by adding an extra
+ // Project and alias the outputs.
+ val aliasedOutput = canonicalizedPlan.output.zip(outputNames).map {
+ case (attr, name) => Alias(attr.withQualifiers(Nil), name)()
+ }
+ val finalPlan = Project(aliasedOutput, SubqueryAlias(finalName,
canonicalizedPlan))
--- End diff --
The top Project in the `finalPlan` still has the name ambiguity issues. I
think it could be still a problem when we use it in the native view supports.
https://github.com/apache/spark/pull/10733
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
