Github user wilson888888888 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11580#discussion_r55933241
--- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
@@ -442,25 +442,25 @@ class CleanerTester(
checkpointIds: Seq[Long] = Seq.empty)
extends Logging {
- val toBeCleanedRDDIds = new HashSet[Int] with SynchronizedSet[Int] ++=
rddIds
- val toBeCleanedShuffleIds = new HashSet[Int] with SynchronizedSet[Int]
++= shuffleIds
- val toBeCleanedBroadcstIds = new HashSet[Long] with
SynchronizedSet[Long] ++= broadcastIds
- val toBeCheckpointIds = new HashSet[Long] with SynchronizedSet[Long] ++=
checkpointIds
+ val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds
--- End diff --
@srowen
I tried to change to val toBeCleanedRDDIds = HashSet(rddIds), but I got
error at
toBeCleanedRDDIds -= rddId
so I will keep val toBeCleanedRDDIds = new HashSet[Int] ++= rddIds
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
