Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/10607#issuecomment-196304722
@sethah If no further comments overnight, I'm going to merge this so you
can move ahead with porting the helper classes to ML and removing the old MLLIB
impl. As part of those tickets, I think we can clean up this ML impl and
interfaces if required (e.g. we could look at removing the`private [ml] train`
method in favour of one in MLLIb that converts RDDs to DataFrame and calls ML,
we can make more stuff private where possible, etc). But I think it'll be a lot
easier to clean things up once everything is in ML.
If any other issues arise from this (including perf regression from larger
scale perf-tests) we can also clean up subsequently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
