Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11297#discussion_r56056326
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -1169,6 +1170,7 @@ object PushPredicateThroughJoin extends 
Rule[LogicalPlan] with PredicateHelper {
               Join(newLeft, newRight, LeftOuter, newJoinCond)
             case FullOuter => f
             case NaturalJoin(_) => sys.error("Untransformed NaturalJoin node")
    +        case UsingJoin(_, _) => sys.error("Untransformed Using join node")
    --- End diff --
    
    Nit: I'm not really sure what the point of these extra checks is.  Is it 
only to remove a warning?  All kinds of things break in the optimizer if the 
plan is unresolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to