Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/11508#issuecomment-196560959
- Please propagate more information about the problem from JIRA into the
description of the PR. This is going to become the commit message.
- Every bug fix needs a regression test. Manual testing is not
acceptable. Try and take the problem reported by the user and distill it to
the simplest possible code that reproduces the problem. Add this to
`DatasetSuite`.
- 0 is probably not a great estimate for the size of an object.
- Instead of special casing the handling in one place, it would probably
be better to implment this function for ObjectType. Probably pick the same
value we use for binary or string types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
