Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1439#discussion_r15435889
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala 
---
    @@ -114,6 +77,7 @@ case class HiveTableScan(
         val columnInternalNames = 
neededColumnIDs.map(HiveConf.getColumnInternalName(_)).mkString(",")
     
         if (attributes.size == relation.output.size) {
    +      // TODO what if duplicated attributes queried?
    --- End diff --
    
    A `HiveTableScan` will be only created by `SQLContext#pruneFilterProject` 
and `pruneFilterProject` will make sure there is no duplicated attributes. 
Let's add a comment to explain it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to