Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11684#discussion_r56202965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -199,7 +199,12 @@ case class Divide(left: Expression, right: Expression)
extends BinaryArithmetic
override def symbol: String = "/"
override def decimalMethod: String = "$div"
- override def nullable: Boolean = true
+ override def nullable: Boolean = (left.nullable ||
+ !(!right.nullable && right.isInstanceOf[Literal] &&
+ ((right.asInstanceOf[Literal].value.isInstanceOf[Decimal] &&
--- End diff --
This is too complicated, do you think it worth to save the the
nullable-checking?
If it does not have good speed up (by benchmark), I'd like to not do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
