Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9229#issuecomment-196945850
@avulanov I made one pass on the implementation. Besides inline comments:
* It is good to keep the size checks as safe guards.
* For methods that modify the input args in-place, we need to document the
behavior. Is it for both input and output, or just the output.
I'll make another pass after update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
