Github user cfregly commented on the pull request:
https://github.com/apache/spark/pull/1434#issuecomment-50253400
@mateiz -
this is a completely brand-new, from-scratch implementation.
parviz's old code was actually a Scala port of the Java-based Kinesis
sample app found here:
https://github.com/aws/aws-sdk-java/blob/master/src/samples/AmazonKinesisApplication/SampleRecordProcessor.java
this was fine for a quick/dirty sample of kinesis functionality, but my
goal was to make this code more reusable, testable, readable, configurable,
production-ready, and well-documented. the old code did not support the new
Streaming 1.0 API and extras/ build structure (due to ASL-license). i also
updated the AWS Java SDK and Kinesis Client Libraries to their latest versions.
here is parviz's PR for reference/comparison:
https://github.com/apache/spark/pull/223.
i've addressed all of the comments provided in the old PR to speed up the
acceptance of this new PR.
thanks and i look forward to getting this merged!
-chris
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
