Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11658#discussion_r56272587
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
 ---
    @@ -185,8 +185,7 @@ case class Alias(child: Expression, name: String)(
       override def sql: String = {
         val qualifiersString =
           if (qualifiers.isEmpty) "" else 
qualifiers.map(quoteIdentifier).mkString("", ".", ".")
    -    val aliasName = if (isGenerated) s"$name#${exprId.id}" else s"$name"
    --- End diff --
    
    Is isGenerated still needed? (if not, we do not need to remove it in this 
PR). Also, what is the reason of this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to