GitHub user nongli opened a pull request:

    https://github.com/apache/spark/pull/11792

    [SPARK-13981][SQL] Defer evaluating variables within Filter operator.

    ## What changes were proposed in this pull request?
    
    This improves the Filter codegen to defer loading variables within the 
generated
    filter code. This is useful since the filter logic naturally short circuits 
and
    the deferred logic doesn't need to be run.
    
    ## How was this patch tested?
    
    On tpcds q55, this fixes the regression from introducing the IsNotNull 
predicates.
    
    ```
    TPCDS Snappy:                       Best/Avg Time(ms)    Rate(M/s)   Per 
Row(ns)
    
--------------------------------------------------------------------------------
    q55  (master)                            5562 / 5822         20.7          
48.3
    q55  (this patch)                        5079 / 5190         22.7          
44.1
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nongli/spark spark-13981

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11792.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11792
    
----
commit 29e408d61f3557b1c5df343d039ef74d1c6e9ab3
Author: Nong Li <[email protected]>
Date:   2016-03-17T19:55:02Z

    [SPARK-13981][SQL] Defer evaluating variables within Filter operator.
    
    This improves the Filter codegen to defer loading variables within the 
generated
    filter code. This is useful since the filter logic naturally short circuits 
and
    the deferred logic doesn't need to be run.
    
    On tpcds q55, this fixes the regression from introducing the IsNotNull 
predicates.
    
    TPCDS Snappy:                       Best/Avg Time(ms)    Rate(M/s)   Per 
Row(ns)
    
--------------------------------------------------------------------------------
    q55  (master)                            5562 / 5822         20.7          
48.3
    q55  (this patch)                        5079 / 5190         22.7          
44.1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to