Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11578#discussion_r56616608
--- Diff:
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
@@ -41,6 +41,12 @@ trait RandomSampler[T, U] extends Pseudorandom with
Cloneable with Serializable
/** take a random sample */
def sample(items: Iterator[T]): Iterator[U]
--- End diff --
I think it is doable. However, I am not sure we want to completely remove
iterator-based implementation. @mengxr What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
