GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/11774
[SPARK-13948] MiMa check should catch if the visibility changes to private
MiMa excludes are currently generated using both the current Spark
version's classes and Spark 1.2.0's classes, but this doesn't make sense: we
should only be ignoring classes which were `private` in the previous Spark
version, not classes which became private in the current version.
This patch updates `dev/mima` to only generate excludes with respect to the
previous artifacts that MiMa checks against. It also updates `MimaBuild` so
that `excludeClass` only applies directly to the class being excluded and not
to its companion object (since a class and its companion object can have
different accessibility).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark SPARK-13948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11774
----
commit bf161da15e56b53933aede4653eab4258efdb864
Author: Josh Rosen <[email protected]>
Date: 2016-03-16T22:40:23Z
Don't automatically exclude companion objects of private[spark] classes.
commit 77613e633bfa9fcf9f6117a5b6307fe3611ed00c
Author: Josh Rosen <[email protected]>
Date: 2016-03-16T23:40:37Z
Use previous artifact JARs to generate excludes
commit 4605c79b7ea65735f0c1356e95f5f348b70d40d7
Author: Josh Rosen <[email protected]>
Date: 2016-03-16T23:49:41Z
Add MiMa excludes so checks pass for now.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
