Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11553#discussion_r56467230
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -49,6 +49,19 @@ private[feature] trait QuantileDiscretizerBase extends
Params
/** @group getParam */
def getNumBuckets: Int = getOrDefault(numBuckets)
+
+ /**
+ * Relative error (see approxQuantile documentation for description).
Must be >= 0.
+ * default: 0.01
--- End diff --
This still says `default: 0.01`. I think we should say something like `By
default, the relative error will be in the range [0.001, 0.01]. The exact value
is computed based on the number of buckets, decreasing as the number of buckets
increases.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
