Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11775#discussion_r56474974
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala 
---
    @@ -237,6 +237,8 @@ class SparkHadoopUtil extends Logging {
         }
       }
     
    +  def pathExists( p: Path, config: Configuration): Boolean = 
p.getFileSystem(config).exists(p)
    --- End diff --
    
    There are some style issues in these changes like extra spaces before `p`. 
Also I don't think it's useful to make this method, since you use it once, and 
it isn't replacing the other 30-40 instances of this. It doesn't add much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to