Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10731#discussion_r56610085
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ---
    @@ -202,3 +203,14 @@ object Unions {
         }
       }
     }
    +
    +/**
    + * Extractor for retrieving Int value.
    + */
    +object IntegerIndex {
    +  def unapply(a: Any): Option[Int] = a match {
    +    case Literal(a: Int, IntegerType) => Some(a)
    +    case UnaryMinus(IntegerLiteral(v)) => Some(-v)
    --- End diff --
    
    This line is used for catching the illegal case:
    ```scala
          sql("SELECT * FROM testData2 ORDER BY -1 DESC, b ASC").collect()
    ```
    
    I plan to keep it untouched in the PR. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to