Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11734#issuecomment-197617528
I don't think that MiMa is necessarily capable of detecting this problem
for things which are evolved to become `private[spark]` because Scala
package-private methods become public from Java's point of view and MiMa uses a
Java-centric type of binary compatibility; see
https://github.com/typesafehub/migration-manager/issues/34. My understanding is
that `private[spark]` is a source compatibility issue from Scala's POV and thus
is out-of-scope for what MiMa currently detects.
However, I think it's true that we will fail to detect a class which
becomes straight-up `private`, so we should definitely fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
