Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/11663#discussion_r56406609
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -32,13 +35,17 @@ class Param(object):
.. versionadded:: 1.3.0
"""
- def __init__(self, parent, name, doc, expectedType=None):
+ def __init__(self, parent, name, doc, expectedType=None,
typeConverter=None):
if not isinstance(parent, Identifiable):
raise TypeError("Parent must be an Identifiable but got type
%s." % type(parent))
self.parent = parent.uid
self.name = str(name)
self.doc = str(doc)
self.expectedType = expectedType
+ if expectedType is not None:
+ warnings.warn("expectedType is deprecated and will be removed
in 2.1.0, " +
+ "use typeConverter instead.")
--- End diff --
"use typeConverter instead, as a keyword argument"
Also, I'd put this same message in the docstring too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
