Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1218#discussion_r15481704
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -212,3 +260,13 @@ private[history] class FsHistoryProvider(conf: 
SparkConf) extends ApplicationHis
       private def getMonotonicTimeMs() = System.nanoTime() / (1000 * 1000)
     
     }
    +
    +private class FsApplicationHistoryInfo(
    +  val logDir: String,
    +  id: String,
    +  name: String,
    +  startTime: Long,
    +  endTime: Long,
    +  lastUpdated: Long,
    +  sparkUser: String)
    +  extends ApplicationHistoryInfo(id, name, startTime, endTime, 
lastUpdated, sparkUser)
    --- End diff --
    
    looks like a case class to me. Also, the format should be:
    
    ```
    private case class FsApplicationHistoryInfo(
        logDir: String,
        id: String
        ...
      extends ApplicationHistoryInfo(...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to