GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/11859

    [SPARK-14004][follow-up] Implementations of NonSQLExpression should not 
override sql method

    ## What changes were proposed in this pull request?
    
    There is only one exception: `PythonUDF`. However, I don't think the 
`PythonUDF#` prefix is useful, as we can only create python udf under python 
context. This PR removes the `PythonUDF#` prefix from `PythonUDF.toString`, so 
that it doesn't need to overrde `sql`.
    
    
    ## How was this patch tested?
    
    existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark tmp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11859
    
----
commit ce7d4f2120be4158ef2dc059fe3e78a64c829778
Author: Wenchen Fan <[email protected]>
Date:   2016-03-21T11:36:42Z

    Implementations of NonSQLExpression should not override sql method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to