Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1346#discussion_r15481834
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
 ---
    @@ -17,11 +17,12 @@
     
     package org.apache.spark.sql.catalyst.expressions
     
    +import com.typesafe.scalalogging.slf4j.Logging
    --- End diff --
    
    We should use either Spark Logging or Spark SQL logging. (Ideally we will 
be removing catalyst's dependence on Spark solely for the logging code, but I'm 
okay with either ATM.)  We shouldn't hard code this library here though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to