Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11860#discussion_r56837875
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -365,21 +365,10 @@ object SQLConf {
               "unmatching partitions can be eliminated earlier.")
     
       val NATIVE_VIEW = booleanConf("spark.sql.nativeView",
    -    defaultValue = Some(false),
    -    doc = "When true, CREATE VIEW will be handled by Spark SQL instead of 
Hive native commands.  " +
    -          "Note that this function is experimental and should ony be used 
when you are using " +
    -          "non-hive-compatible tables written by Spark SQL.  The SQL 
string used to create " +
    -          "view should be fully qualified, i.e. use `tbl1`.`col1` instead 
of `*` whenever " +
    -          "possible, or you may get wrong result.",
    -    isPublic = false)
    -
    -  val CANONICAL_NATIVE_VIEW = booleanConf("spark.sql.nativeView.canonical",
         defaultValue = Some(true),
    -    doc = "When this option and spark.sql.nativeView are both true, Spark 
SQL tries to handle " +
    -          "CREATE VIEW statement using SQL query string generated from 
view definition logical " +
    -          "plan.  If the logical plan doesn't have a SQL representation, 
we fallback to the " +
    -          "original native view implementation.",
    -    isPublic = false)
    +    doc = "When true, CREATE VIEW statement will be handled by Spark SQL 
instead of Hive native " +
    +          "command, using SQL query string generated from view definition 
logical plan.  Note " +
    +          "that this feature may break in some corner cases, you can 
disable it to workaround.")
    --- End diff --
    
    We can remove the last sentence and instead suggest the user to turn it off 
when `toSQL` fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to