Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11326#discussion_r56853646
--- Diff:
core/src/test/resources/HistoryServerExpectations/one_app_multi_attempt_json_expectation.json
---
@@ -11,6 +14,9 @@
"completed" : true
}, {
"attemptId" : "1",
+ "startTimeEpoch" : 1426533910242,
+ "endTimeEpoch" : 1426533945177,
+ "lastUpdatedEpoch" : "",
--- End diff --
Oh I get it, it blanks the lastUpdated field so this is effectively not
compared. (Would it just be easier to strip these?) Although I appreciate it
doesn't matter in the sense that it's just for purposes of a diff, it seems
like it's worth making the value it substitutes valid, like a 0. Or just
removing it if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]