Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/11851#discussion_r56880696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -71,6 +71,15 @@ object Canonicalize extends {
case GreaterThanOrEqual(l, r) if l.hashCode() > r.hashCode() =>
LessThanOrEqual(r, l)
case LessThanOrEqual(l, r) if l.hashCode() > r.hashCode() =>
GreaterThanOrEqual(r, l)
+ case Not(GreaterThan(l, r)) if l.hashCode() > r.hashCode() =>
GreaterThan(r, l)
+ case Not(GreaterThan(l, r)) => LessThanOrEqual(l, r)
+ case Not(LessThan(l, r)) if l.hashCode() > r.hashCode() => LessThan(r,
l)
+ case Not(LessThan(l, r)) => GreaterThanOrEqual(l, r)
+ case Not(GreaterThanOrEqual(l, r)) if l.hashCode() > r.hashCode() =>
GreaterThanOrEqual(r, l)
+ case Not(GreaterThanOrEqual(l, r)) => LessThan(l, r)
+ case Not(LessThanOrEqual(l, r)) if l.hashCode() > r.hashCode() =>
LessThanOrEqual(r, l)
+ case Not(LessThanOrEqual(l, r)) => GreaterThan(l, r)
--- End diff --
Thank you for review. I'll add more tests there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
