Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11209#discussion_r56906895
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
 ---
    @@ -423,6 +345,121 @@ case class Murmur3Hash(children: Seq[Expression], 
seed: Int) extends Expression
           case udt: UserDefinedType[_] => computeHash(input, udt.sqlType, 
result, ctx)
         }
       }
    +
    +  protected def hasherClassName: String
    +}
    +
    +/**
    + * Base class for interpreted hash functions.
    + */
    +abstract class InterpretedHashFunction[E] {
    --- End diff --
    
    Should we just change this to always reutrn long and downcast where we 
currently use int? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to