Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11791#discussion_r56916240
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala ---
@@ -1074,7 +1074,7 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with BeforeAndAfterE
assert(memoryStore.currentUnrollMemoryForThisTask === 0)
// Unroll with all the space in the world. This should succeed.
- var putResult = memoryStore.putIterator("unroll", smallList.iterator,
StorageLevel.MEMORY_ONLY)
+ var putResult = memoryStore.putIteratorAsValues("unroll",
smallList.iterator)
--- End diff --
Good call; yes. I'll add some, since there's actually a couple of new
branches that need coverage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
