Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11645#discussion_r56917090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.state
+
+import java.util.{Timer, TimerTask}
+
+import scala.collection.mutable
+import scala.util.control.NonFatal
+
+import org.apache.hadoop.conf.Configuration
+
+import org.apache.spark.{SparkConf, SparkEnv}
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.catalyst.expressions.UnsafeRow
+import org.apache.spark.sql.types.StructType
+
+
+/** Unique identifier for a [[StateStore]] */
+case class StateStoreId(rootLocation: String, operatorId: Long,
partitionId: Int)
+
+/**
+ * Base trait for a versioned key-value store used for streaming
aggregations
+ */
+trait StateStore {
+
+ /** Unique identifier of the store */
+ def id: StateStoreId
+
+ /** Version of the data in this store before committing updates. */
+ def version: Long
+
+ /**
+ * Update the value of a key using the value generated by the update
function.
+ * This can be called only after prepareForUpdates() has been called in
the same thread.
+ */
+ def update(key: UnsafeRow, updateFunc: Option[UnsafeRow] => UnsafeRow):
Unit
+
+ /**
+ * Remove keys that match the following condition.
+ * This can be called only after prepareForUpdates() has been called in
the current thread.
+ */
+ def remove(condition: UnsafeRow => Boolean): Unit
+
+ /**
+ * Commit all the updates that have been made to the store.
+ * This can be called only after prepareForUpdates() has been called in
the current thread.
+ */
+ def commit(): Long
+
+ /** Cancel all the updates that have been made to the store. */
+ def cancel(): Unit
--- End diff --
How is this different than just not committing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
