Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11874#discussion_r57079697
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
    @@ -316,17 +324,42 @@ private[spark] class MemoryStore(
         *
         * @param blockId the ID of the block we are freeing space for, if any
         * @param space the size of this block
    --- End diff --
    
    This variable name / comment is outdated; `space` is the amount of memory 
that we'd like to free via eviction, which is not necessarily equal to the 
whole size of the block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to