Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11891#discussion_r57091067
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -597,6 +619,107 @@ private[hive] class HiveMetastoreCatalog(val client:
HiveClient, hive: HiveConte
}
}
+ private def convertToOrcRelation(metastoreRelation: MetastoreRelation):
LogicalRelation = {
--- End diff --
How much of this is duplicated with `convertToParquetRelation`? It would
be awesome if we could just make this `ConvertToHadoopFSRelation` and handle
all the cases (or just ORC/Parquet through a common path). I'd have to look
closer, but I think its likely that the parquet specific things (like
parquetOption with the merged schema) are actually not required anymore.
The fact that this code path is parquet specific predates a common
interface for reading files in Spark SQL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
