Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11904#discussion_r57112464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -414,6 +399,22 @@ class Analyzer(
}
/**
+ * Build a project list for Project/Aggregate and expand the star if
possible
+ */
+ private def buildExpandedProjectList(
+ exprs: Seq[NamedExpression],
+ plan: UnaryNode): Seq[NamedExpression] = {
+ exprs.flatMap {
+ // Using Dataframe/Dataset API: testData2.groupBy($"a",
$"b").agg($"*")
+ case s: Star => s.expand(plan.child, resolver)
+ // Using SQL API without running ResolveAlias: SELECT * FROM
testData2 group by a, b
+ case UnresolvedAlias(s: Star, _) => expandStarExpression(s,
plan.child) :: Nil
--- End diff --
do we need this case? I think the next case can also handle it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
