GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/11912
[SPARK-14092] [SQL] move shouldStop() to end of while loop
## What changes were proposed in this pull request?
This PR rollback some changes in #11274 , which introduced some performance
regression when do a simple aggregation on parquet scan with one integer column.
Does not really understand how this change introduce this huge impact,
maybe related show JIT compiler inline functions. (saw very different stats
from profiling).
## How was this patch tested?
Manually run the parquet reader benchmark, before this change:
```
Intel(R) Core(TM) i7-4558U CPU @ 2.80GHz
Int and String Scan: Best/Avg Time(ms) Rate(M/s) Per
Row(ns) Relative
-------------------------------------------------------------------------------------------
SQL Parquet Vectorized 2391 / 3107 43.9
22.8 1.0X
```
After this change
```
Java HotSpot(TM) 64-Bit Server VM 1.7.0_60-b19 on Mac OS X 10.9.5
Intel(R) Core(TM) i7-4558U CPU @ 2.80GHz
Int and String Scan: Best/Avg Time(ms) Rate(M/s) Per
Row(ns) Relative
-------------------------------------------------------------------------------------------
SQL Parquet Vectorized 2032 / 2626 51.6
19.4 1.0X```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davies/spark fix_regression
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11912.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11912
----
commit b31115d63b9a1e354cab730ba4e897fa87b4ebb0
Author: Davies Liu <[email protected]>
Date: 2016-03-23T06:19:45Z
move shouldStop() to end of while loop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
