Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11810#discussion_r57196629
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
@@ -79,16 +79,16 @@ case class Filter(condition: Expression, child:
SparkPlan)
// Split out all the IsNotNulls from condition.
private val (notNullPreds, otherPreds) =
splitConjunctivePredicates(condition).partition {
- case IsNotNull(a) if child.output.contains(a) => true
+ case IsNotNull(a) if a.references.subsetOf(child.outputSet) => true
--- End diff --
This is not correct, for example, `IsNotNull(IsNull(a))` does not means `a`
can not be `null`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
