Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/11836#discussion_r57201552
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
@@ -83,26 +154,6 @@ class TestHiveContext(sc: SparkContext) extends
HiveContext(sc) {
hiveconf.set("hive.plan.serialization.format", "javaXML")
- lazy val warehousePath = Utils.createTempDir(namePrefix = "warehouse-")
-
- lazy val scratchDirPath = {
- val dir = Utils.createTempDir(namePrefix = "scratch-")
- dir.delete()
- dir
- }
-
- private lazy val temporaryConfig =
newTemporaryConfiguration(useInMemoryDerby = false)
-
- /** Sets up the system initially or after a RESET command */
- protected override def configure(): Map[String, String] = {
- super.configure() ++ temporaryConfig ++ Map(
--- End diff --
Looks like as long as we make `temporaryConfig` a constant value, it is
fine to have
```
TestHiveContext.hiveClientConfigurations(hiveconf, warehousePath,
scratchDirPath)
.foreach { case (k, v) => metadataHive.runSqlHive(s"SET $k=$v") }
```
in the reset. I feel reset those confs is still needed just in case we
override any of those confs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
